Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom operation related changes #2108

Merged
merged 12 commits into from
Feb 28, 2020
Merged

Custom operation related changes #2108

merged 12 commits into from
Feb 28, 2020

Conversation

oxarbitrage
Copy link
Member

Address some of the comments(the easier ones) from #2093 related to custom operations plugin.

abitmore
abitmore reviewed Feb 17, 2020
View reviewed changes
Copy link
Member

@abitmore abitmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@abitmore
Copy link
Member

Forgot to submit the review :-/

abitmore
abitmore previously approved these changes Feb 27, 2020
View reviewed changes
Copy link
Member

@abitmore abitmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@abitmore abitmore dismissed their stale review February 27, 2020 19:31

cli_tests is failing

@abitmore
Copy link
Member

The general_storage test case in cli_tests is failing, likely due to the 45K block number change.

@oxarbitrage
Copy link
Member Author

Failing by the renaming, sorry about that, fixed now.

abitmore
abitmore approved these changes Feb 28, 2020
View reviewed changes
Copy link
Member

@abitmore abitmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@abitmore abitmore merged commit 5cee6e5 into release Feb 28, 2020
@abitmore abitmore deleted the 4.0_comments branch February 28, 2020 09:24
@MichelSantos MichelSantos mentioned this pull request May 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abitmore abitmore abitmore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0 - Protocol Upgrade Release
Development

Successfully merging this pull request may close these issues.
2 participants
@oxarbitrage @abitmore