dont do genesis if _es_objects_start_es_after_block is > 0

[oxarbitrage]

For issue #1951

[pmconrad]

IMO the check should be added here instead.

[oxarbitrage]

Makes sense but i dont want to do:

if (!my->genesis() && options.count("es-objects-start-es-after-block") && options["es-objects-start-es-after-block"].as<uint32_t>() > 0)

Do you mind if i put the entire block of connects:

bitshares-core/libraries/plugins/es_objects/es_objects.cpp

Lines 319 to 343 in 4b3c2d9

	database().applied_block.connect([this](const signed_block &b) {
	if(b.block_num() == 1) {
	if (!my->genesis())
	FC_THROW_EXCEPTION(graphene::chain::plugin_exception, "Error populating genesis data.");
	}
	});
	database().new_objects.connect([this]( const vector<object_id_type>& ids, const flat_set<account_id_type>& impacted_accounts ) {
	if(!my->index_database(ids, "create"))
	{
	FC_THROW_EXCEPTION(graphene::chain::plugin_exception, "Error creating object from ES database, we are going to keep trying.");
	}
	});
	database().changed_objects.connect([this]( const vector<object_id_type>& ids, const flat_set<account_id_type>& impacted_accounts ) {
	if(!my->index_database(ids, "update"))
	{
	FC_THROW_EXCEPTION(graphene::chain::plugin_exception, "Error updating object from ES database, we are going to keep trying.");
	}
	});
	database().removed_objects.connect([this](const vector<object_id_type>& ids, const vector<const object*>& objs, const flat_set<account_id_type>& impacted_accounts) {
	if(!my->index_database(ids, "delete"))
	{
	FC_THROW_EXCEPTION(graphene::chain::plugin_exception, "Error deleting object from ES database, we are going to keep trying.");
	}
	});

after all the commands:

bitshares-core/libraries/plugins/es_objects/es_objects.cpp

Lines 346 to 384 in 4b3c2d9

	if (options.count("es-objects-elasticsearch-url")) {
	my->_es_objects_elasticsearch_url = options["es-objects-elasticsearch-url"].as<std::string>();
	}
	if (options.count("es-objects-auth")) {
	my->_es_objects_auth = options["es-objects-auth"].as<std::string>();
	}
	if (options.count("es-objects-bulk-replay")) {
	my->_es_objects_bulk_replay = options["es-objects-bulk-replay"].as<uint32_t>();
	}
	if (options.count("es-objects-bulk-sync")) {
	my->_es_objects_bulk_sync = options["es-objects-bulk-sync"].as<uint32_t>();
	}
	if (options.count("es-objects-proposals")) {
	my->_es_objects_proposals = options["es-objects-proposals"].as<bool>();
	}
	if (options.count("es-objects-accounts")) {
	my->_es_objects_accounts = options["es-objects-accounts"].as<bool>();
	}
	if (options.count("es-objects-assets")) {
	my->_es_objects_assets = options["es-objects-assets"].as<bool>();
	}
	if (options.count("es-objects-balances")) {
	my->_es_objects_balances = options["es-objects-balances"].as<bool>();
	}
	if (options.count("es-objects-limit-orders")) {
	my->_es_objects_limit_orders = options["es-objects-limit-orders"].as<bool>();
	}
	if (options.count("es-objects-asset-bitasset")) {
	my->_es_objects_asset_bitasset = options["es-objects-asset-bitasset"].as<bool>();
	}
	if (options.count("es-objects-index-prefix")) {
	my->_es_objects_index_prefix = options["es-objects-index-prefix"].as<std::string>();
	}
	if (options.count("es-objects-keep-only-current")) {
	my->_es_objects_keep_only_current = options["es-objects-keep-only-current"].as<bool>();
	}
	if (options.count("es-objects-start-es-after-block")) {
	my->_es_objects_start_es_after_block = options["es-objects-start-es-after-block"].as<uint32_t>();
	}

?

This way i can do:

if(b.block_num() == 1 && my->_es_objects_start_es_after_block > 0) {

[pmconrad]

Ok but I think it must be my->_es_objects_start_es_after_block == 0

[pmconrad]

Thanks!