Issue 1800: Temp-account market fee sharing #1870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abitmore
reviewed
Jul 26, 2019
|
|
||
| auto registrar = ( seller.registrar == GRAPHENE_TEMP_ACCOUNT && head_block_time() >= HARDFORK_CORE_1800_TIME ) | ||
| ? GRAPHENE_COMMITTEE_ACCOUNT | ||
| : seller.registrar; |
There was a problem hiding this comment.
Should be done for both registrar and referrer.
pmconrad
suggested changes
Jul 29, 2019
There was a problem hiding this comment.
- IMO this is premature, the discussion in Temp-account market fee sharing issue #1800 has not reached consensus yet.
This PR changes vesting balance IDs and thus breaks consensus.Sorry, I was wrong.
ryanRfox
modified the milestones:
4.0.0 - Protocol Upgrade Release,
Future Protocol Upgrade Release
abitmore
modified the milestones:
Future Protocol Upgrade Release,
5.0.0 - Protocol Upgrade Release
abitmore
modified the milestones:
5.0.0 - Protocol Upgrade Release,
4.0.0 - Protocol Upgrade Release
abitmore
approved these changes
Apr 5, 2020
This was referenced Apr 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done according to conversation (#1800 (comment))