[#443] Fix GitHub adapter broken after GitHub redesign #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the GitHub adapter to work with the redesigned issue pages. As we do not know now GitHub Enterprise looks like for the majority of users, we keep the previous logic for the "legacy" strategy of the adapter. To keep the change and the adapter simple, I dropped support selecting issues on the issues page. Instead, we only support the issue show pages now. On the long run, it may make sense to look into supporting GitHub projects too. The new GitHub adapter supports GitHub issue types and won't look for the "bug" label any more. Ticket: #443 Fixes: #443
klappradla
changed the title
andreasknoepfle
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the GitHub adapter to work with the redesigned issue pages.
As we do not know now GitHub Enterprise looks like for the majority of
users, we keep the previous logic for the "legacy" strategy of the
adapter.
To keep the change and the adapter simple, I dropped support selecting
issues on the issues page. Instead, we only support the issue show pages
now. On the long run, it may make sense to look into supporting GitHub
projects too.
The new GitHub adapter supports GitHub issue types and won't look for
the "bug" label any more.
Ticket: #443
Fixes: #443