Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add descriptor checksum to wallet #603

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

rustaceanrob
Copy link
Contributor

Description

Adding from methods suggested in #596

Notes to the reviewers

public_descriptor was giving me grief when I tried to test it in python, so I'm starting simple here

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@reez
Copy link
Collaborator

reez commented Oct 7, 2024

This will be a nice thanks for adding 👍

Copy link
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 53d654c.

Thanks!

@thunderbiscuit thunderbiscuit merged commit 53d654c into bitcoindevkit:master Oct 8, 2024
25 checks passed
@rustaceanrob rustaceanrob deleted the desc-10-7 branch October 15, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants