Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose derivation_index method on wallet type #579

Merged

Conversation

thunderbiscuit
Copy link
Member

@thunderbiscuit thunderbiscuit commented Jul 31, 2024

Title says it all.

The method allows you to get the highest derivation index used for a given keychain.

Changelog notice

Added
    - Add `wallet.derivation_index` method on Wallet type [#579]

[#579]: /~https://github.com/bitcoindevkit/bdk-ffi/pull/579

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7aadf32

@thunderbiscuit thunderbiscuit force-pushed the feature/derivation-index branch from 7aadf32 to c322c03 Compare August 29, 2024 16:38
@thunderbiscuit thunderbiscuit self-assigned this Aug 29, 2024
@thunderbiscuit thunderbiscuit force-pushed the feature/derivation-index branch from c322c03 to 9d1a276 Compare August 29, 2024 17:06
@thunderbiscuit thunderbiscuit merged commit 9d1a276 into bitcoindevkit:master Aug 29, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants