Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add add_data function for TxBuilder op_return #163

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Add add_data function for TxBuilder op_return #163

merged 1 commit into from
Jun 23, 2022

Conversation

waterst0ne
Copy link
Contributor

@waterst0ne waterst0ne commented Jun 10, 2022 •
edited
Loading

fixes #132

@waterst0ne waterst0ne force-pushed the add_data_implement branch 2 times, most recently from f9ce873 to 410eb82 Compare June 16, 2022 17:52
@waterst0ne waterst0ne changed the title add_data fxn for txbuilder op_return Add add_data function for TxBuilder op_return Jun 16, 2022
@waterst0ne waterst0ne marked this pull request as ready for review June 16, 2022 17:58
@notmandatory notmandatory self-requested a review June 16, 2022 18:00
@thunderbiscuit
Copy link
Member

thunderbiscuit commented Jun 16, 2022 •
edited
Loading

I tested this and broadcast a transaction out with a message 🔥 🔥 🔥.

The Kotlin type on the other side of this is List<UByte> so it takes a bit of manipulating but it worked on the first try.

@thunderbiscuit thunderbiscuit added this to the Release 0.8.0 milestone Jun 17, 2022
thunderbiscuit
thunderbiscuit requested changes Jun 22, 2022
View reviewed changes
Copy link
Member

@thunderbiscuit thunderbiscuit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very small nit, otherwise I think this is ready for merge.

Tested ACK 410eb82.

src/lib.rs Outdated Show resolved Hide resolved
@waterst0ne waterst0ne force-pushed the add_data_implement branch from 410eb82 to 57ec72e Compare June 22, 2022 21:54
@waterst0ne waterst0ne force-pushed the add_data_implement branch from 57ec72e to 548217e Compare June 22, 2022 22:00
notmandatory
notmandatory approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! ACK 548217e

@thunderbiscuit thunderbiscuit self-requested a review June 23, 2022 11:18
@thunderbiscuit thunderbiscuit merged commit 6be22da into bitcoindevkit:master Jun 23, 2022
@thunderbiscuit thunderbiscuit mentioned this pull request Jun 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thunderbiscuit thunderbiscuit thunderbiscuit approved these changes

@notmandatory notmandatory notmandatory approved these changes

Assignees

@waterst0ne waterst0ne

Labels
None yet
Projects
BDK-Bindings
Archived in project
Milestone
Release 0.8.0
Development

Successfully merging this pull request may close these issues.

Add TxBuilder addData method
3 participants
@waterst0ne @thunderbiscuit @notmandatory