Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.18: Backport "Add -ignorepartialspends to list of ignored wallet options" #16189

Merged
merged 2 commits into from
Jun 13, 2019
Merged

0.18: Backport "Add -ignorepartialspends to list of ignored wallet options" #16189

merged 2 commits into from
Jun 13, 2019

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Jun 11, 2019

First run clang-format on the wallet options list (review with --word-diff-regex=.). This is not a backport.

Then backport Github-Pull: #15913

@maflcko maflcko added this to the 0.18.1 milestone Jun 11, 2019
@luke-jr
Copy link
Member

luke-jr commented Jun 11, 2019

What is the reason for not doing a backport of the first commit?

@Empact
Copy link
Contributor

Empact commented Jun 11, 2019

@luke-jr could certainly see applying a script to the file would be easier and more failsafe than rebasing the commit.

@promag
Copy link
Contributor

promag commented Jun 12, 2019

ACK 106471d.

@laanwj
Copy link
Member

laanwj commented Jun 13, 2019 •
edited
Loading

ACK 106471d

@laanwj laanwj merged commit 106471d into bitcoin:0.18 Jun 13, 2019
laanwj added a commit that referenced this pull request Jun 13, 2019
@laanwj
Merge #16189: 0.18: Backport "Add -ignorepartialspends to list of ign…
9c29bc7 
…ored wallet options"

106471d Bugfix: dummywallet: Add -ignorepartialspends to list of ignored wallet options (Luke Dashjr)
206c30f dummywallet: Reformat ignored wallet options list (MarcoFalke)

Pull request description:

  First run clang-format on the wallet options list (review with `--word-diff-regex=.`). This is not a backport.

  Then backport Github-Pull: #15913

ACKs for commit 106471:
  promag:
    ACK 106471d.
  laanwj:
    ACK 106471d

Tree-SHA512: 3e6eb7997aa32ef7385842614bac8cac56f86b6dde949cfbbd33b4387e713bf5f65e40ee3e4228ac43dfe50829169175b80ddeaac8a714ad8a38175638123f5d
@maflcko maflcko deleted the 1906-18Backport branch June 13, 2019 10:43
@promag promag mentioned this pull request Oct 18, 2019
Merged
@jamescowens jamescowens mentioned this pull request Jun 13, 2020
Merged
@curtcurt380
Copy link

I need help I don't understand nothing going on. I don't know how to find my wallets, I dont understand what a node is?, I don't understand please help me thank .

@Empact
Copy link
Contributor

Empact commented Jul 23, 2020

I need help I don't understand nothing going on. I don't know how to find my wallets, I dont understand what a node is?, I don't understand please help me thank .

@curtcurt380 this isn't the place for user support. I would suggest looking into the docs on bitcoin.org, starting with the FAQ.

If you can't get your bearings there, I'd reach out to one of the online user communities for help. r/bitcoin has a lot of helpful people.

@bitcoin bitcoin locked and limited conversation to collaborators Jul 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Backport
Projects
None yet
Milestone
0.18.1
Development

Successfully merging this pull request may close these issues.
6 participants
@maflcko @luke-jr @Empact @promag @laanwj @curtcurt380