🐛 Fixes after the rebase on the Syncer refactoring #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Festal <dfestal@redhat.com>
davidfestal
force-pushed
the
pr/bipuladh/2214
branch
from
93c244c to
e1c0c2a
Compare
davidfestal
changed the title
yana1205
reviewed
Jan 12, 2023
| } | ||
| return informer.Lister(), nil | ||
| }, | ||
| syncTargetName: syncTargetKey, |
There was a problem hiding this comment.
Hi, excuse me for interrupting.
I am very interesting to Upsync feature and am trying it on this branch.
Maybe, is this typo?
syncTargetName: syncTargetKey, => syncTargetName: syncTargetName,?
I'm facing an issue at /~https://github.com/davidfestal/kcp/blob/pr/bipuladh/2214/pkg/syncer/upsync/upsync_process.go#L60 that calculates the downstream namespace hash prefix but results in a different value from the actually used one.
|
Thanks @yana1205. I'll have a look into it. |
|
Yes, its seems a bug. I'll include the fix in my current changes |
|
Thanks! @davidfestal |
davidfestal
pushed a commit
that referenced
this pull request
Jan 13, 2023
bipuladh
added a commit
that referenced
this pull request
Jan 30, 2023
davidfestal
pushed a commit
that referenced
this pull request
Feb 7, 2023
davidfestal
pushed a commit
that referenced
this pull request
Feb 7, 2023
davidfestal
pushed a commit
that referenced
this pull request
Feb 7, 2023
davidfestal
pushed a commit
that referenced
this pull request
Feb 7, 2023
davidfestal
pushed a commit
that referenced
this pull request
Feb 8, 2023
davidfestal
pushed a commit
that referenced
this pull request
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Festal dfestal@redhat.com
Summary
Fixes after the rebase on the Syncer refactoring
Disclaimer
Still to be done after this PR is merged to kcp-dev#2214 :
specsub-resource doesn't make sense.