Cleaning #8
Merged
Cleaning #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptdtan
reviewed
Apr 2, 2019
src/Harmony.cpp
Outdated
| assert(i < (result.size() - 1) && "Index must be smaller than number of columns"); | ||
| //result.fill(2); //default is 2 | ||
| for (int i = 0; i < col_idx.length(); ++i) { | ||
| assert( 0 < col_idx[i] && col_idx[i] <= (result.size()) && "Index must be smaller than number of columns"); |
There was a problem hiding this comment.
Lỗi của anh. Nên throw exception ra chứ không nên assert, ngó qua bên API của anh Hoà nhé.
ptdtan
reviewed
Apr 2, 2019
src/Harmony.cpp
Outdated
| for (c_it = mtx.begin_col(i); c_it != mtx.end_col(i); ++c_it) { | ||
| if (cluster[i] != cid) | ||
| continue; | ||
| assert(bin_cnt > 0); |
ptdtan
reviewed
Apr 2, 2019
src/Harmony.cpp
Outdated
| //res[i].first += count[i][j].first * (prob[j]); | ||
| //res[i].second += count[i][j].second * (prob[j]); | ||
| if (cnt_both >= thres) { | ||
| std::get<0>(res[i]) += HarmonicMean((double)cnt_in/total_in, |
There was a problem hiding this comment.
dùng ngoặc vuông cho index thứ hai luôn đươc không em?
ptdtan
reviewed
Apr 2, 2019
src/Harmony.cpp
Outdated
| for (int i = 0; i < mtx.n_cols; ++i) | ||
| if (cluster[i] == cid) | ||
| ++total_in; | ||
| for (int i = 0; i < mtx.n_cols; ++i) { |
There was a problem hiding this comment.
chỗ này total_in bằng với col_idx.size() mà em.
(cherry picked from commit 05d4ac4ec9f959de500fd1126b78ef5d25a833b3)
(cherry picked from commit 69770a6a0856304a6a035b357511a4b076ab1a68)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.