Vucinick patch #10
Merged
Vucinick patch #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please check if this is correct.
`run_single_sample()` and `run_integration()` are soft-deprecated since scdrake 1.4.0. Using `run_single_sample_r()` and `run_integration_r()` instead.
Clusters were ordered in the following manner 1, 10, 11, 12, 13 .. etc. Changed to 1, 2, 3, 4 etc.
If numbered clusters, order by numbers. Otherwise, keep it as is.
Bug noticed by Lucie Pfeiferova. Error when tryint to create a tibble: Column name `k1` must not be duplicated. Tibble wouldn't have unique column names because best would be a part of the k values. Fixed by taking only unique values.
gorgitko
reviewed
Jul 15, 2024
There was a problem hiding this comment.
Good job @vucinick! I left a small comment, maybe just my misunderstanding.
You can also remove these forgotten commented lines in /~https://github.com/bioinfocz/scdrake/pull/10/files#diff-80094c1be9601ba6522be922f9abc07e36cf96a340be7529976f810f8e6a63c7R590-R594
EDIT: I've fixed the test runner script and CI now fails correctly, see /~https://github.com/bioinfocz/scdrake/actions/runs/9942667887/job/27464672026?pr=10#step:12:1001
Could you fix it, please? 🙏
gorgitko
approved these changes
Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys,
While using scdrake, there were a few aesthetic and technical problems I encountered. Here are my (simple) fixes. :)
Short summary of introduced changes: