Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global search doesn't work if sorting is disabled #133

Closed
nesl247 opened this issue Aug 8, 2014 · 2 comments
Closed

Global search doesn't work if sorting is disabled #133

nesl247 opened this issue Aug 8, 2014 · 2 comments

Comments

@nesl247
Copy link
Contributor

nesl247 commented Aug 8, 2014

Currently you are checking to see if a column is orderable in order to perform a global search. You should instead be checking to see if it is searchable.

On /~https://github.com/bllim/laravel4-datatables-package/blob/master/src/Bllim/Datatables/Datatables.php#L517

Change: if (isset($columns_copy[$i]) && $this->input['columns'][$i]['orderable'] == "true")

To: if (isset($columns_copy[$i]) && $this->input['columns'][$i]['searchable'] == "true")

@mvolo
Copy link

mvolo commented Aug 20, 2014

This fix worked for me.
Thanks nesl !

@ktunkiewicz
Copy link

Sorry for late reply, I was very busy this summer... You are right, I didn't notice that. This will be changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants