fix: Amazon EC2 ID getting matched a lot #229
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚠ Pull Requests not made with this template will be automatically closed 🔥
Prerequisites
Why do we need this pull request?
The EC2 regex was getting matched to almost everything that had hyphen in-between. Even
bee-san
was EC2 ID. :)I have made it more specific. According to Amazon they all start with
i-
. Until 2016 there were 8 characters after the hyphen and since 2016 there are 17 characters.Source: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/resource-ids.html
I also think characters are
a-f
but I am not 100% sure about it.What GitHub issues does this fix?
Copy / paste of output
Please copy and paste the output of PyWhat with your new addition using an example that tests this addition below: