Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

U+276F Extended version looks too big #2603

Closed
atauzki opened this issue Nov 30, 2024 · 8 comments
Closed

U+276F Extended version looks too big #2603

atauzki opened this issue Nov 30, 2024 · 8 comments
Labels
Milestone

Comments

@atauzki
Copy link

atauzki commented Nov 30, 2024

image


  • Your font version: 32.2.1
  • Your font variant: Fixed
  • Your operating system (name and version): Windows 11 26100
  • Your application using Iosevka: Windows Terminal
@be5invis
Copy link
Owner

be5invis commented Dec 4, 2024

About height or width?

@atauzki
Copy link
Author

atauzki commented Dec 4, 2024

the height

@jmcwilliams403
Copy link
Contributor

FWIW one of the pairs of dingbat ornamental angle "brackets" (/) is actually supposed to be based on guillemets (/) not angle brackets (/) hence its different name in Unicode than the other two pairs (///).

@be5invis
Copy link
Owner

Resolved in #2623. This symbol now follows Guillmets' dimension.

@real-or-random
Copy link
Contributor

FWIW one of the pairs of dingbat ornamental angle "brackets" (/) is actually supposed to be based on guillemets (/) not angle brackets (/) hence its different name in Unicode than the other two pairs (///).

That's certainly true, but given that these are dingbats and in particular ornaments, that doesn't mean that the dimensions need to be the same. And most fonts seem to make them tall. See for example page 4, top left corner, of the Unicode spec PDF for a direct comparison with the normal quotation marks. (I'm aware that the shapes are not normative)

These ornaments are often used as a terminal prompt (as in the screenshot in the opening comment) because they are tall in most fonts, e.g., the tide prompt for the fish shell uses these.

So this fix broke/changed my prompt, and I assume this will affect many many users.

Sure, I can change my prompt to use a different character (and I will), but since there is no clear right or wrong here, I believe reverting this change will be a good thing for most users.

@Ved-un
Copy link

Ved-un commented Jan 12, 2025

Don't do that, fix it back to the way it was, please.

This has disfigured the prompt in the terminal for many people.

@Logo121

This comment has been minimized.

@be5invis
Copy link
Owner

#2648 should solve this. Height is now selectable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants