-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
U+276F Extended version looks too big #2603
Comments
About height or width? |
the height |
FWIW one of the pairs of dingbat ornamental angle "brackets" ( |
Resolved in #2623. This symbol now follows Guillmets' dimension. |
That's certainly true, but given that these are dingbats and in particular ornaments, that doesn't mean that the dimensions need to be the same. And most fonts seem to make them tall. See for example page 4, top left corner, of the Unicode spec PDF for a direct comparison with the normal quotation marks. (I'm aware that the shapes are not normative) These ornaments are often used as a terminal prompt (as in the screenshot in the opening comment) because they are tall in most fonts, e.g., the tide prompt for the fish shell uses these. So this fix broke/changed my prompt, and I assume this will affect many many users. Sure, I can change my prompt to use a different character (and I will), but since there is no clear right or wrong here, I believe reverting this change will be a good thing for most users. |
Don't do that, fix it back to the way it was, please. This has disfigured the prompt in the terminal for many people. |
This comment has been minimized.
This comment has been minimized.
#2648 should solve this. Height is now selectable. |
The text was updated successfully, but these errors were encountered: