Semanticdb clear dir #1580
Merged
Semanticdb clear dir #1580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simuons
requested changes
May 20, 2024
| @@ -95,6 +98,15 @@ private static Path ensureEmptyWorkDirectory(Path output, String label) throws I | |||
|
|
|||
| return Files.createDirectories(dir); | |||
| } | |||
|
|
|||
| private static void ensureEmptySemanticDBDirectory(Path output, String label) throws IOException { | |||
There was a problem hiding this comment.
Would it be possible to refactor ensureEmptyWorkDirectory instead of adding this method wich looks almost identical and serves same purpose?
There was a problem hiding this comment.
done.
(But the tests seem flaky... they have failed in different places (unrelated to this change) on last 2 runs).
crt-31
force-pushed
the
semanticdb_clear_dir
branch
2 times, most recently
from
ac909f0 to
9532a4a
Compare
crt-31
force-pushed
the
semanticdb_clear_dir
branch
from
9532a4a to
4ecf61e
Compare
simuons
approved these changes
May 27, 2024
liucijus
approved these changes
May 27, 2024
crt-31
added a commit
to crt-31/rules_scala-devfork
that referenced
this pull request
Jul 1, 2024
* Delete _semanticdb folder before compiling * lint fix * Consolidated some functions in Scalacworker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change clears out and deletes the _semanticdb folder before compiling. This is similar to how ScalacWorker was already clearing out the _classes directory.
Motivation
I ran into a bug where, when you delete a source *.scala file, it's associated semanticdb file remained and was read-only which caused permission errors when the compiler tried to clear the semanticdb output directory.