Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and register toolchains for all SCALA_VERSIONS #1578

Merged
merged 1 commit into from
May 29, 2024

Conversation

aszady
Copy link
Contributor

@aszady aszady commented May 15, 2024

Description

Build and register toolchains for all SCALA_VERSIONS.
There are aliases for toolchains for default Scala version provided – for backward-compatibility, similarly as in #1573.

Motivation

Originally #1290.
Partitioned from #1552.

Co-authored-by: mkuta <mkuta@virtuslab.com>
@aszady aszady marked this pull request as ready for review May 15, 2024 09:19
@aszady aszady requested review from liucijus and simuons as code owners May 15, 2024 09:19
Copy link
Collaborator

@simuons simuons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@aszady
Copy link
Contributor Author

aszady commented May 29, 2024

@liucijus, are you available to review this?

Or possibly we could merge it (as the Governance says: One maintainer approval is enough if PR has been open for more than 7 days.)

@liucijus
Copy link
Collaborator

@liucijus, are you available to review this?

Or possibly we could merge it (as the Governance says: One maintainer approval is enough if PR has been open for more than 7 days.)

Sorry, @aszady, forgot about this one :(

@liucijus liucijus merged commit 670b7ee into bazelbuild:master May 29, 2024
2 checks passed
@aszady aszady deleted the toolchains branch May 29, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants