Fix docc archive bugs #2595
Merged
Fix docc archive bugs #2595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AttilaTheFun
force-pushed
the
lshire-fix-docc-archive
branch
from
66fe215 to
e99d2df
Compare
AttilaTheFun
requested review from
BalestraPatrick,
brentleyjones,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
luispadron
reviewed
Nov 13, 2024
Co-authored-by: Luis Padron <heyluispadron@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds upon and fixes @luispadron 's draft PR:
#2583
Which fixes #2582
docc preview supports previewing with or without a .docc bundle. There were some issues in the argument handling of the template script that stopped this from working when no bundle was provided. This fixes it and additionally fixes the following warning:
warning: '--index' is deprecated. Use '--emit-lmdb-index' indead.
docc preview will emit a json representation by default and we do not need the lmdb index afaict.
Additionally, previously the files within a .docc directory were not included as inputs to the action, so it would not be properly invalidated if you changed the directory contents.
This PR includes all of the files within the data attribute under the .docc directory.