Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make deps target public #62

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Conversation

illicitonion
Copy link
Contributor

rules_rust depends on this, and our stardoc build is sad if we don't have a dep on it.

rules_rust depends on this, and our stardoc build is sad if we don't
have a dep on it.
@illicitonion
Copy link
Contributor Author

If I could bother a maintainer for a release if/when this merges, that'd be handy, thanks!

@fmeum fmeum merged commit 4d34502 into bazel-contrib:main Jul 16, 2024
11 checks passed
@fmeum
Copy link
Member

fmeum commented Jul 16, 2024

I can't create releases at the moment, @meteorcloudy could you?

@meteorcloudy
Copy link
Collaborator

I'll be occupied for the next 2 hours, @Wyverald can you help?

@Wyverald
Copy link
Collaborator

Done. Waiting for publish-to-bcr now

@fmeum
Copy link
Member

fmeum commented Jul 16, 2024

The BCR release failed to access the release archive with a 404. We need to release again.

@Wyverald
Copy link
Collaborator

@illicitonion illicitonion deleted the deps-public branch July 16, 2024 21:17
@meteorcloudy
Copy link
Collaborator

The BCR release failed to access the release archive with a 404. We need to release again.

Was that a bug in the publish-to-bcr bot or the release process?

@fmeum
Copy link
Member

fmeum commented Jul 17, 2024

Since the same process worked on the re-release, I would say it was a GitHub outage. I saw similar failures in other CI pipelines.

@meteorcloudy
Copy link
Collaborator

Ah, thanks for the context!

@meteorcloudy
Copy link
Collaborator

@kormide Any easy way to retrigger publish-to-bcr in such cases? Does it work if we change the release to a prerelease and back?

@Wyverald
Copy link
Collaborator

Since the same process worked on the re-release, I would say it was a GitHub outage. I saw similar failures in other CI pipelines.

I didn't do a re-release; I created the BCR PR myself.

I wonder if it's a race condition between the hook to "upload release archive on release" and "publish-to-BCR on release". Maybe we could simply have publish-to-bcr retry with some long backoff on a 404. See also https://bazelbuild.slack.com/archives/C014RARENH0/p1720549041765859?thread_ts=1720549041.765859&cid=C014RARENH0

@kormide
Copy link

kormide commented Jul 17, 2024

@kormide Any easy way to retrigger publish-to-bcr in such cases? Does it work if we change the release to a prerelease and back?

The only way to retrigger it currently is to delete then re-create the release. This will change in the next quarter or so as we migrate it to a GitHub Action to support provenance; you'll have more manual control over re-running it.

I wonder if it's a race condition between the hook to "upload release archive on release" and "publish-to-BCR on release". Maybe we could simply have publish-to-bcr retry with some long backoff on a 404. See also https://bazelbuild.slack.com/archives/C014RARENH0/p1720549041765859?thread_ts=1720549041.765859&cid=C014RARENH0

Publish To BCR does do retries with backoff, however it's recommended that you upload the release archive as part of publishing the release rather than uploading it afterward to avoid race conditions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants