Bug fixes #158
Merged
Bug fixes #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It wasn't crashing just because VirtualAllocEx does allocation size round up it to next page boundary automatically.
filenameLength declared as DWORD - unsigned long. Expression if (filenameLength < 0) is always false and thus block was never executed.
Missing CloseHandle call added.
Missing CloseHandle call added.
if (warningCount == 0) is always true expression because warningCount assigned to 0 and never changed across function body.
The _tcscpy_s has no sense and overhead because 1st argument of this function is equal to the 3rd.
Expression if (bStatus == NULL) is always false because it was checked before. Thus error handling block never executed. Considering wrong valuable used.
Expression if (hThread == NULL) is always true because hThread is assigned to NULL and don't change up to this line. Thus rest of the code never executed.
There is a resource leak in case of successful execution, there is an invalid handle value passed to CloseHandle in case of failure.
This is a second, more complex fix for this routine. There is a multiple resource leaks and invalid VirtualFreeEx call. Note that truncated pointers in various printfs are still in place as I don't know was it intended or not.
|
Thanks a lot @hfiref0x for the PR. Seems to me all good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix multiple bugs in CreateRemoteThread_Injection
Fix multiple bugs in GetMainThreadId
Fix invalid return value check in QueueUserAPC_Injection routine
Fix invalid return value check in CreateRemoteThread_Injection routine
Update print_os routine
Fix always true expression in PrintAvailabilityReport routine
Fix resource leak in vmware_devices routine
Fix resource leak in vbox_devices routine
Fix invalid comparison in IsBadLibrary routine
Fix invalid memory allocation size in HardwareBreakpoints routine