Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PluralLocalizationFormatter: Fix processing for Singular languages #322

Merged
merged 1 commit into from
Nov 17, 2022

Conversation

axunonb
Copy link
Member

@axunonb axunonb commented Nov 17, 2022

Resolves #320

  • Fix: Throws FormattingException for Singular languages
  • Add unit test for Singular language (Japanese)
  • Auto detection only works with more than 1 format argument.
  • Is recommended to set CanAutoDetect to false. This will be the default in a future version. Added xmdoc with this hint.

* Fix: Throws FormattingException for Singular languages
* Add unit test for Singular language (Japanese)
* Auto detection only works with more than 1 format argument.
* Is recommended to set CanAutoDetect to false. This will be the default in a future version. Added xmdoc with this hint.
* Fix: AppVeyor dotnet test command: remove --no-build
@axunonb axunonb force-pushed the pr/fix-plurallization-auto-detection branch from 88c195a to 2814d0b Compare November 17, 2022 12:02
@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Base: 96% // Head: 96% // Decreases project coverage by -0% ⚠️

Coverage data is based on head (67c3e0a) compared to base (52850db).
Patch coverage: 100% of modified lines in pull request are covered.

❗ Current head 67c3e0a differs from pull request most recent head 2814d0b. Consider uploading reports for the commit 2814d0b to get more accurate results

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #322   +/-   ##
===================================
- Coverage    96%    96%   -0%     
===================================
  Files        91     91           
  Lines      3186   3183    -3     
===================================
- Hits       3070   3067    -3     
  Misses      116    116           
Impacted Files Coverage Δ
...rtFormat/Extensions/PluralLocalizationFormatter.cs 92% <100%> (+3%) ⬆️
...rc/SmartFormat/Extensions/LocalizationFormatter.cs 95% <0%> (-5%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@axunonb axunonb merged commit 3a5ab9f into axuno:main Nov 17, 2022
@axunonb axunonb deleted the pr/fix-plurallization-auto-detection branch November 17, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plural formatter with singular plural rule
1 participant