-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update coldsnap to use aws sdk for rust #145
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to try it in other partitions and/or opt-in regions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might to double-check that it works in other partitions (i.e. double-check that the AWS Rust SDK works the way we expect to). Other than that looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍭
1693b39
to
3859620
Compare
Removed rusoto, updated dependencies for aws-sdk-rust, and updated functions to call the AWS sdk. Removed the client mod, it was no longer necessary with how clients are built in the AWS sdk.
Removed rusoto, updated dependencies for aws-sdk-rust, and updated
functions to call the AWS sdk.
Removed the client mod, it was no longer necessary with how clients are
built in the AWS sdk.
Description of changes:
Removed rusoto and replaced it with the AWS SDK Rust.
Ran the following tests:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.