Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update coldsnap to use aws sdk for rust #145

Merged
merged 1 commit into from
May 20, 2022
Merged

Conversation

rpkelly
Copy link
Contributor

@rpkelly rpkelly commented May 18, 2022

Removed rusoto, updated dependencies for aws-sdk-rust, and updated
functions to call the AWS sdk.

Removed the client mod, it was no longer necessary with how clients are
built in the AWS sdk.

Description of changes:
Removed rusoto and replaced it with the AWS SDK Rust.

Ran the following tests:

  • Unit tests were updated to use the Rust SDK
  • Generated 2 GB random file, uploaded, downloaded and confirmed that hash remained the same
  • Confirmed that profile and region settings work as intended

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rpkelly rpkelly marked this pull request as ready for review May 18, 2022 01:05
Copy link
Contributor

@webern webern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to try it in other partitions and/or opt-in regions?

Cargo.toml Outdated Show resolved Hide resolved
src/bin/coldsnap/main.rs Outdated Show resolved Hide resolved
src/download.rs Outdated Show resolved Hide resolved
src/wait.rs Show resolved Hide resolved
src/upload.rs Show resolved Hide resolved
src/upload.rs Outdated Show resolved Hide resolved
src/bin/coldsnap/main.rs Outdated Show resolved Hide resolved
@jpculp jpculp self-requested a review May 18, 2022 19:29
Copy link
Contributor

@webern webern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might to double-check that it works in other partitions (i.e. double-check that the AWS Rust SDK works the way we expect to). Other than that looks good!

Cargo.toml Outdated Show resolved Hide resolved
Copy link
Contributor

@zmrow zmrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍭

Cargo.toml Outdated Show resolved Hide resolved
deny.toml Outdated Show resolved Hide resolved
src/upload.rs Outdated Show resolved Hide resolved
src/upload.rs Outdated Show resolved Hide resolved
src/wait.rs Outdated Show resolved Hide resolved
src/bin/coldsnap/main.rs Outdated Show resolved Hide resolved
src/bin/coldsnap/main.rs Outdated Show resolved Hide resolved
@rpkelly rpkelly force-pushed the develop branch 2 times, most recently from 1693b39 to 3859620 Compare May 19, 2022 22:20
src/bin/coldsnap/main.rs Show resolved Hide resolved
Removed rusoto, updated dependencies for aws-sdk-rust, and updated
functions to call the AWS sdk.

Removed the client mod, it was no longer necessary with how clients are
built in the AWS sdk.
@rpkelly rpkelly merged commit 2c8f0e7 into awslabs:develop May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants