chore: put nonprod environments before prod when listing #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandyleo26
changed the title
|
Thanks for doing this! And so quickly, we really appreciate it! Also thanks for updating the contributing doc 🤦♂️ I’ll take a look later this weekend! |
efekarakus
approved these changes
Mar 7, 2020
| @@ -28,7 +28,7 @@ This document describes how to set up a development environment and submit your | |||
|
|
|||
| From the repository root run: | |||
|
|
|||
| `git remote add upstream git@github.com:aws/amazon-ecs-cli` | |||
| `git remote add upstream git@github.com:aws/amazon-ecs-cli-v2` | |||
There was a problem hiding this comment.
😄 thanks for fixing this!
efekarakus
changed the title
kohidave
approved these changes
Mar 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when listing environments, put nonprod environments first so user keep typing "Enter" will not accidentally deploy to production.
fixes #716
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.