Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): migrate AWS SDK for JavaScript v2 APIs to v3 #5828

Merged
merged 1 commit into from
Jun 3, 2024
Merged

chore(cli): migrate AWS SDK for JavaScript v2 APIs to v3 #5828

merged 1 commit into from
Jun 3, 2024

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jun 3, 2024

AWS SDK for JavaScript v2 will enter maintenance mode on September 8, 2024 and reach end-of-support on September 8, 2025. For more information, check blog post at https://a.co/cUPnyil

This PR migrates v2 APIs in internal/pkg/cli to use v3.

These APIs were introduced in #3022, and were manually tested.
If they're run on Lambda, they're likely expected to fail error [ERR_MODULE_NOT_FOUND]: Cannot find package 'aws-sdk' after upgrading to Node.js 20

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@trivikr trivikr requested a review from a team as a code owner June 3, 2024 16:43
@trivikr trivikr requested review from Lou1415926 and removed request for a team June 3, 2024 16:43
Copy link

github-actions bot commented Jun 3, 2024

🍕 Here are the new binary sizes!

Name New size (kiB) size (kiB) Delta (%)
macOS (amd) 58076 58072 +0.01
macOS (arm) 59152 59136 +0.03
linux (amd) 50932 50924 +0.02
linux (arm) 50176 50180 ❤️ -0.01
windows (amd) 47968 47964 +0.01

@mergify mergify bot merged commit eef2df1 into aws:mainline Jun 3, 2024
12 checks passed
@trivikr trivikr deleted the cli-js-sdk-v3 branch June 3, 2024 17:28
@dannyrandall
Copy link
Contributor

Hi @trivikr, this update is now released in v1.34.0: /~https://github.com/aws/copilot-cli/releases/tag/v1.34.0! Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants