-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: watch flag skips files specified by dockerignore #5565
chore: watch flag skips files specified by dockerignore #5565
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## mainline #5565 +/- ##
============================================
+ Coverage 70.01% 70.02% +0.01%
============================================
Files 302 303 +1
Lines 46534 46584 +50
Branches 299 299
============================================
+ Hits 32579 32621 +42
- Misses 12370 12376 +6
- Partials 1585 1587 +2 ☔ View full report in Codecov by Sentry. |
🍕 Here are the new binary sizes!
|
I'm changing this PR to not skip files in the Another scenario we may want to filter out dockerignore entries is the following:
and we have a We made the decision not to include this right now because it's enough of an edge case that we don't see it happening often, but I'd like to document this use case so that our decision is clear 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is our decision on the sidecar build's dockerignore?
sidecars:
startup:
build:
dockerfile: "path/to/dockerfile"
This PR is already pretty big, I'd prefer to do it separately if need be, but I don't think it's very important. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also adds a message for when the
--watch
flag restart timer begins.The docker cli reads
.dockerignore
files here, this abides by the same implementation. Then, as specified by the docker build context,.dockerignore
file matching is done by go'sfilepath.Match
function.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.