fix: respect image.location uri for containers
#5555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lou1415926
force-pushed
the
fix/container/image/build
branch
from
3cdbee2 to
f1e340e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## mainline #5555 +/- ##
============================================
- Coverage 70.05% 70.05% -0.01%
============================================
Files 302 302
Lines 46335 46338 +3
Branches 301 301
============================================
+ Hits 32459 32460 +1
- Misses 12302 12305 +3
+ Partials 1574 1573 -1 ☔ View full report in Codecov by Sentry. |
|
🍕 Here are the new binary sizes!
|
iamhopaul123
approved these changes
Dec 12, 2023
Comment on lines
-98
to
+101
| imageURI := rc.PushedImages[name].URI() | ||
| var imageURI string | ||
| if image, ok := rc.PushedImages[name]; ok { | ||
| imageURI = image.URI() | ||
| } |
There was a problem hiding this comment.
Not feedback but I found this snippet of code to be really interesting in Go!
The new code is definitely a more idiomatic way to approach the problem because it doesn't use what feels like a side effect of the language, but they actually have the exact same output. I was curious so I wrote this in the Go Playground to test.
❤️ Great catch on this since it's not actually part of the bug.
Lou1415926
force-pushed
the
fix/container/image/build
branch
from
f1e340e to
5c366ff
Compare
CaptainCarpensir
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #5501 (comment)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.