Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refer to more specific TargetGroup name for imported ALB #5478

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

huanjani
Copy link
Contributor

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@huanjani huanjani requested a review from a team as a code owner November 14, 2023 22:55
@huanjani huanjani requested review from KollaAdithya and removed request for a team November 14, 2023 22:55
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e9002b3) 70.04% compared to head (d6fe540) 70.05%.

Additional details and impacted files
@@            Coverage Diff            @@
##           mainline    #5478   +/-   ##
=========================================
  Coverage     70.04%   70.05%           
=========================================
  Files           302      302           
  Lines         46064    46064           
  Branches        309      309           
=========================================
+ Hits          32264    32268    +4     
+ Misses        12235    12232    -3     
+ Partials       1565     1564    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

🍕 Here are the new binary sizes!

Name New size (kiB) size (kiB) Delta (%)
macOS (amd) 55596 55208 +0.70
macOS (arm) 56580 56168 +0.73
linux (amd) 48780 48456 +0.67
linux (arm) 48064 47748 +0.66
windows (amd) 45992 45684 +0.67

@mergify mergify bot merged commit 0449888 into aws:mainline Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants