feat: add support for docker build args to the task run command #5377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briercliffe
requested review from
CaptainCarpensir
and removed request for
a team
iamhopaul123
approved these changes
Oct 11, 2023
| @@ -1193,6 +1199,7 @@ func BuildTaskRunCmd() *cobra.Command { | |||
| cmd.Flags().StringVarP(&vars.groupName, taskGroupNameFlag, nameFlagShort, "", taskGroupFlagDescription) | |||
|
|
|||
| cmd.Flags().StringVar(&vars.dockerfilePath, dockerFileFlag, defaultDockerfilePath, dockerFileFlagDescription) | |||
| cmd.Flags().StringToStringVar(&vars.dockerfileBuildArgs, dockerFileBuildArgsFlag, nil, dockerFileBuildArgsFlagDescription) | |||
There was a problem hiding this comment.
Can you add an example to the [task run help menu] about how we can run task from dockerfile 🙏
There was a problem hiding this comment.
I added an example to the help menu showing how to use the --build-args flag. Thanks for the suggestion!
|
🍕 Here are the new binary sizes!
|
Lou1415926
approved these changes
Oct 11, 2023
| @@ -192,6 +193,8 @@ var ( | |||
| imageFlagDescription = fmt.Sprintf(`The location of an existing Docker image. | |||
| Cannot be specified with --%s or --%s.`, dockerFileFlag, dockerFileContextFlag) | |||
| dockerFileFlagDescription = fmt.Sprintf(`Path to the Dockerfile. | |||
| Cannot be specified with --%s.`, imageFlag) | |||
| dockerFileBuildArgsFlagDescription = fmt.Sprintf(`Key-value pairs converted to --build-args. | |||
| Cannot be specified with --%s.`, imageFlag) | |||
There was a problem hiding this comment.
Cannot be specified with --%s.`, imageFlag
aw yay thank you for adding this in the help menu message !
Lou1415926
added
the
do-not-merge
Lou1415926
removed
the
do-not-merge
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## mainline #5377 +/- ##
=========================================
Coverage 69.86% 69.87%
=========================================
Files 297 297
Lines 45190 45198 +8
Branches 287 287
=========================================
+ Hits 31574 31580 +6
- Misses 12079 12080 +1
- Partials 1537 1538 +1
☔ View full report in Codecov by Sentry. |
KollaAdithya
pushed a commit
to KollaAdithya/copilot-cli
that referenced
this pull request
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to pass build args into the docker build when running the
copilot task runcommand.Addresses #5376
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.