Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --manifest flag to svc show #3715

Merged
merged 6 commits into from
Jul 6, 2022

Conversation

efekarakus
Copy link
Contributor

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@efekarakus efekarakus requested a review from a team as a code owner July 5, 2022 21:44
@efekarakus efekarakus requested review from iamhopaul123 and removed request for a team July 5, 2022 21:44
@@ -198,6 +194,8 @@ func buildEnvShowCmd() *cobra.Command {
cmd.Flags().BoolVar(&vars.shouldOutputJSON, jsonFlag, false, jsonFlagDescription)
cmd.Flags().BoolVar(&vars.shouldOutputResources, resourcesFlag, false, envResourcesFlagDescription)
cmd.Flags().BoolVar(&vars.shouldOutputManifest, manifestFlag, false, manifestFlagDescription)
_ = cmd.Flags().MarkHidden(manifestFlag)

cmd.MarkFlagsMutuallyExclusive(jsonFlag, manifestFlag)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty cool!

@@ -124,7 +125,7 @@ func (d *serviceStackDescriber) Params() (map[string]string, error) {
return descr.Parameters, nil
}

// Params returns the outputs of the service stack.
// Outputs returns the outputs of the service stack.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂

Copy link
Contributor

@huanjani huanjani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple nits; otherwise, looks good!

@huanjani huanjani added the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Jul 6, 2022
@efekarakus efekarakus removed the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants