-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add --manifest
flag to svc show
#3715
Conversation
@@ -198,6 +194,8 @@ func buildEnvShowCmd() *cobra.Command { | |||
cmd.Flags().BoolVar(&vars.shouldOutputJSON, jsonFlag, false, jsonFlagDescription) | |||
cmd.Flags().BoolVar(&vars.shouldOutputResources, resourcesFlag, false, envResourcesFlagDescription) | |||
cmd.Flags().BoolVar(&vars.shouldOutputManifest, manifestFlag, false, manifestFlagDescription) | |||
_ = cmd.Flags().MarkHidden(manifestFlag) | |||
|
|||
cmd.MarkFlagsMutuallyExclusive(jsonFlag, manifestFlag) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pretty cool!
@@ -124,7 +125,7 @@ func (d *serviceStackDescriber) Params() (map[string]string, error) { | |||
return descr.Parameters, nil | |||
} | |||
|
|||
// Params returns the outputs of the service stack. | |||
// Outputs returns the outputs of the service stack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple nits; otherwise, looks good!
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.