feat(pipeline): allow additional policy to build role

[paragbhingre]

Resolves #2755

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

[dannyrandall]

what would you think about just having this as yaml.Node or map[string]any and marshaling it directly into the pipeline template? and just letting cloudformation do the validation?

[iamhopaul123]

Agreed. I think right now it is pretty much the same as what CFN has (we don't do any abstraction or setting default values for them). We could just let them specify the json policy document as a string.

[paragbhingre]

The only thing I thought of is CFN template errors are little difficult for the customers to understand and solve that is why I kept it this way that we will guide customers with more user friendly errors.

[iamhopaul123]

Yeah but additional policies is a pretty advanced feature and most likely those users who need to specify additional policies they already have the json policy document handy.

[efekarakus]

Yay awesome, this will provide a lot more flexibility to customers! 🎉

Is it also possible to add a local integration test in for example

copilot-cli/internal/pkg/deploy/cloudformation/stack/bb_pipeline_integration_test.go

Line 25 in 1caa364

func TestBB_Pipeline_Template(t *testing.T) {

to make sure the additonal policy is rendered in the template?

[efekarakus]

Looks great! We can after fixing the integ test

[dannyrandall]

just some small things but looks good!!

[huanjani]

Resolves #1689, #2546, #2535, #2104