chore: add hidden --manifest flag to env show #3597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efekarakus
force-pushed
the
chore/env-show-manifest
branch
from
16ec03e to
c484db0
Compare
iamhopaul123
approved these changes
May 24, 2022
internal/pkg/cli/env_show.go
Outdated
| func (o *showEnvOpts) validateApp() error { | ||
| _, err := o.store.GetApplication(o.appName) | ||
| if err != nil { | ||
| return fmt.Errorf("validate application name '%s': %v", o.appName, err) |
There was a problem hiding this comment.
I feel the reason why we need this strange pattern for error wrapping (validate ... but the actual API we call is GetApplication) is because we probably need a validate package.
There was a problem hiding this comment.
you think so? maybe a cli/validate package isn't a bad idea for us to move all of our validate.go logic
Lou1415926
approved these changes
May 25, 2022
Lou1415926
added
the
do-not-merge
efekarakus
removed
the
do-not-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.