fix: ensure EnvManagerRole template has permissions to upload artifacts #3567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannyrandall
approved these changes
May 12, 2022
Lou1415926
added
the
do-not-merge
Lou1415926
approved these changes
May 12, 2022
| pad := strings.Repeat(" ", numSpaces) | ||
|
|
||
| // Create the additional permissions needed with the appropriate indentation. | ||
| permissions := fmt.Sprintf(`- Sid: PatchPutObjectsToArtifactBucket |
There was a problem hiding this comment.
Noice! Naming it Patch... ensures that we can upgrade environment using the env template without fear for "change set has no changes" error.
efekarakus
removed
the
do-not-merge
| if len(tpl.Resources.ManagerRole.Properties.Policies) == 0 { | ||
| return errors.New("unable to find policies for the EnvironmentManagerRole") | ||
| } | ||
| // lines and columns are 1-indexed, so we have to substract one from each. |
There was a problem hiding this comment.
substract
i finally found one 😇😇😇😇😇😇😇😇😇😇😇😇😇😇😇😇😇😇😇😇😇😇😇😇😇😇😇😇😇😇😇😇😇😇😇😇😇😇😇😇😇😇😇😇😇😇😇😇😇😇😇😇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #3556
Tested
env upgradefrom the following versions:copilot v1.0copilot v1.13copilot v1.17By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.