[WIP] feat(client-s3): manually written s3 region info provider #2696
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2696 +/- ##
=======================================
Coverage ? 60.81%
=======================================
Files ? 531
Lines ? 27890
Branches ? 6863
=======================================
Hits ? 16960
Misses ? 10930
Partials ? 0 Continue to review full report at Codecov.
|
trivikr
force-pushed
the
endpoints-destructuring-test
branch
from
eb26863 to
fc34447
Compare
| signingRegion: options.regionHash[region].signingRegion, | ||
| }), | ||
| ...(options.regionHash[region]?.signingService && { | ||
| signingService: options.regionHash[region].signingService, |
There was a problem hiding this comment.
Will this handle the signingService for partition like: /~https://github.com/aws/aws-models/blob/master/endpoints.json#L3240?
There was a problem hiding this comment.
Seems like for now the signing service is same across the partitions for every services. So this should be fine.
There was a problem hiding this comment.
The final PR which handles signing service for partition is posted on fork at trivikr#172
It will be posted upstream once getRegionInfo PR is merged.
|
Closing in favor of codegen trivikr#172 which would be posted upstream once #2701 is merged. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Issue
Internal JS-2773
Description
Manually written s3 region info provider for design discussion
Testing
Integration tests
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.