Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run workflows on feature branches #2141

Merged
merged 1 commit into from
May 26, 2023

Conversation

isaiahvita
Copy link
Contributor

Amend github workflow config to run workflows on feature branches along with main. Pulled syntax from the github documentation page
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions

@isaiahvita isaiahvita requested a review from a team as a code owner May 26, 2023 15:11
branches: [ main ]
branches:
- main
- 'feat-**'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this just be feat-* (one *)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in github syntax, ** to matches any character. * matches any character except /.
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet

im fine with either, i kind of just copied one of the examples in the github documentation page which used **

@isaiahvita isaiahvita requested a review from a team May 26, 2023 16:51
@wty-Bryant wty-Bryant self-requested a review May 26, 2023 16:53
@isaiahvita isaiahvita merged commit f07c0b6 into aws:main May 26, 2023
@isaiahvita isaiahvita deleted the feat-run-feature-workflows branch May 26, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants