Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable RSA keygen becnhmarks by default #2206

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Conversation

andrewhop
Copy link
Contributor

@andrewhop andrewhop commented Feb 19, 2025

Description of changes:

The current filter logic in the speed tool is a bit weird. It's not possible to run all the benchmarks because RSA key gen was off by default. If you pass in the filter "RSAKeyGen" you get the keygen benchmarks and all the other RSA benchmarks. This change updates it to be treated the same as all the other benchmarks.

The RSA key gen benchmarks are still a little weird because they override the timeout which is why they are slower and take more time. For now the canary use case is fine.

Testing:

The CI will run this benchmark with all the libcryptos we expect to support.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@andrewhop andrewhop requested a review from a team as a code owner February 19, 2025 00:41
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.04%. Comparing base (5cdc082) to head (ae58755).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2206   +/-   ##
=======================================
  Coverage   79.04%   79.04%           
=======================================
  Files         612      612           
  Lines      106164   106222   +58     
  Branches    15003    15008    +5     
=======================================
+ Hits        83915    83964   +49     
- Misses      21594    21606   +12     
+ Partials      655      652    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewhop andrewhop merged commit c8993cf into aws:main Feb 19, 2025
118 of 119 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants