Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python 3.13 patch #2026

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Conversation

WillChilds-Klein
Copy link
Contributor

@WillChilds-Klein WillChilds-Klein commented Dec 2, 2024

Description of changes:

A recent commit in python 3.13 broke our patch. This fixes it.

Call-outs:

  • n/a

Testing:

  • CI

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@WillChilds-Klein WillChilds-Klein marked this pull request as ready for review December 2, 2024 15:57
@WillChilds-Klein WillChilds-Klein requested a review from a team as a code owner December 2, 2024 15:57
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.68%. Comparing base (5982853) to head (92fc1f2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2026      +/-   ##
==========================================
- Coverage   78.69%   78.68%   -0.02%     
==========================================
  Files         598      598              
  Lines      103326   103323       -3     
  Branches    14687    14687              
==========================================
- Hits        81310    81295      -15     
- Misses      21366    21378      +12     
  Partials      650      650              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nebeid nebeid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: many empty lines have an extra space.

@WillChilds-Klein WillChilds-Klein merged commit d6a4786 into aws:main Dec 2, 2024
114 of 119 checks passed
torben-hansen pushed a commit to torben-hansen/aws-lc that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants