Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PKCS8 in agreement::PrivateKey::from_private_key_der #713

Merged
merged 2 commits into from
Feb 28, 2025

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Feb 27, 2025

Description of changes:

  • Recent refactoring dropped support for parsing PKCS8 from agreement::PrivateKey::from_private_key_der. This PR restores that support.
  • Bump version to 1.12.5

Call-outs:

  • We had no function to serialize an ECDH private key to PKCS8. In order to test this, this functionality needed to be added.

Testing:

  • Updated test.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner February 27, 2025 22:59
@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 92.86%. Comparing base (c358484) to head (4e7836f).
Report is 177 commits behind head on main.

Files with missing lines Patch % Lines
aws-lc-rs/src/agreement.rs 83.33% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #713      +/-   ##
==========================================
- Coverage   95.80%   92.86%   -2.94%     
==========================================
  Files          61       70       +9     
  Lines        8143     9561    +1418     
  Branches        0     9561    +9561     
==========================================
+ Hits         7801     8879    +1078     
- Misses        342      413      +71     
- Partials        0      269     +269     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth justsmth merged commit ad169b3 into aws:main Feb 28, 2025
254 of 264 checks passed
@justsmth justsmth deleted the ecdh-pkcs8 branch February 28, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants