Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify nid after parsing EC #705

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Feb 20, 2025

Issues:

Addresses: #704

Description of changes:

  • Verify nid of curve after parsing.

Testing:

Added new test.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner February 20, 2025 21:51
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.89%. Comparing base (c358484) to head (775c098).
Report is 175 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #705      +/-   ##
==========================================
- Coverage   95.80%   92.89%   -2.91%     
==========================================
  Files          61       70       +9     
  Lines        8143     9538    +1395     
  Branches        0     9538    +9538     
==========================================
+ Hits         7801     8860    +1059     
- Misses        342      412      +70     
- Partials        0      266     +266     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth justsmth requested a review from andrewhop February 20, 2025 22:04
@justsmth justsmth merged commit 5c4fa5c into aws:main Feb 20, 2025
263 of 264 checks passed
@justsmth justsmth deleted the ec-parse-nid-check branch February 20, 2025 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants