Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression in EcdsaKeyPair::from_private_key_der #686

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Feb 3, 2025

Description of changes:

Call-outs:

Testing

  • Added a test to prevent future regression.
  • I verified that this fixes the test failure in rcgen.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner February 3, 2025 17:18
@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 96.55172% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.89%. Comparing base (c358484) to head (c731228).
Report is 162 commits behind head on main.

Files with missing lines Patch % Lines
aws-lc-rs/src/ec/key_pair.rs 95.83% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #686      +/-   ##
==========================================
- Coverage   95.80%   92.89%   -2.91%     
==========================================
  Files          61       69       +8     
  Lines        8143     9565    +1422     
  Branches        0     9565    +9565     
==========================================
+ Hits         7801     8885    +1084     
- Misses        342      399      +57     
- Partials        0      281     +281     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth justsmth requested a review from skmcgrail February 3, 2025 17:53
@justsmth justsmth force-pushed the fix-EcdsaKeyPair-from_private_key_der branch from fd642cf to bf1c273 Compare February 3, 2025 19:56
@justsmth justsmth force-pushed the fix-EcdsaKeyPair-from_private_key_der branch from 1791308 to c731228 Compare February 3, 2025 20:51
@justsmth justsmth merged commit 4220081 into aws:main Feb 4, 2025
263 of 264 checks passed
@justsmth justsmth deleted the fix-EcdsaKeyPair-from_private_key_der branch February 4, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants