-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle specific exception codes on RCI call. #4457
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BinSquare
force-pushed
the
master
branch
5 times, most recently
from
December 23, 2024 17:48
49c48be
to
7a5da69
Compare
BinSquare
changed the title
Data model changes to consume ThrottlingExceptions.
Handle specific exception codes on RCI call.
Dec 23, 2024
BinSquare
force-pushed
the
master
branch
4 times, most recently
from
December 27, 2024 18:15
48fc82a
to
7591552
Compare
timj-hh
reviewed
Dec 27, 2024
timj-hh
previously approved these changes
Dec 27, 2024
xxx0624
reviewed
Dec 27, 2024
xxx0624
previously approved these changes
Dec 27, 2024
amogh09
reviewed
Dec 30, 2024
BinSquare
force-pushed
the
master
branch
11 times, most recently
from
December 31, 2024 21:52
9d38a72
to
683ded4
Compare
BinSquare
force-pushed
the
master
branch
10 times, most recently
from
January 1, 2025 01:24
3569039
to
a3e49ad
Compare
singholt
previously approved these changes
Jan 2, 2025
amogh09
reviewed
Jan 2, 2025
BinSquare
force-pushed
the
master
branch
4 times, most recently
from
January 2, 2025 18:54
e350d77
to
6fe572f
Compare
amogh09
approved these changes
Jan 2, 2025
singholt
approved these changes
Jan 2, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implementation details
Changes are implemented on agent calling RCi.
Testing
Added 2 new tests, one to verify throttlingError returns exitcode 1 + one to verify ClientException will result in exit code 5 i.e. the terminal state for agent.
New tests cover the changes:
Description for the changelog
Terminally exit on unrecoverable RCI exception errors.
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
No
Does this PR include the addition of new environment variables in the README?
No
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.