Update README and PR Template for sensitive environment variables #4271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hozkaya2000
changed the title
singholt
reviewed
Aug 7, 2024
hozkaya2000
force-pushed
the
env-variable-clarification
branch
4 times, most recently
from
21b2a3f to
dae74a0
Compare
singholt
previously approved these changes
Aug 7, 2024
mye956
previously approved these changes
Aug 7, 2024
hozkaya2000
dismissed stale reviews from mye956 and singholt
The base branch was changed.
hozkaya2000
force-pushed
the
env-variable-clarification
branch
from
dae74a0 to
88e54c1
Compare
singholt
approved these changes
Aug 7, 2024
mye956
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is an update to the readme to remove certain environment variables from the list that may be confused as customer input. It also updates the PR template to ensure that our logs collector is up to date based on the latest additional environment variables.
Description for the changelog
Update environment variable details in README.md and PR Template
Does this PR include breaking model changes? If so, Have you added transformation functions?
No
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.