Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove the engagement time attribute in first screen view #43

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

zhu-xiaowei
Copy link
Contributor

  • PR title and description conform to Pull Request guidelines.

Description of changes:

  1. remove the negative _engagement_time_msec value in first screen view event

How did you test these changes?
assert the first screen view event does not have the attribute _engagement_time_msec

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zhu-xiaowei zhu-xiaowei added the bug Something isn't working label Sep 20, 2023
@zhu-xiaowei zhu-xiaowei requested a review from zxkane September 20, 2023 05:52
@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.07% ⚠️

Comparison is base (ba43cfb) 86.52% compared to head (1dfc410) 86.45%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #43      +/-   ##
============================================
- Coverage     86.52%   86.45%   -0.07%     
- Complexity      400      402       +2     
============================================
  Files            39       39              
  Lines          1447     1447              
  Branches        127      128       +1     
============================================
- Hits           1252     1251       -1     
- Misses          122      123       +1     
  Partials         73       73              
Files Changed Coverage Δ
...tion/clickstream/client/AutoRecordEventClient.java 96.96% <60.00%> (-2.01%) ⬇️
...solution/clickstream/ActivityLifecycleManager.java 97.87% <100.00%> (-0.05%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhu-xiaowei zhu-xiaowei marked this pull request as draft September 20, 2023 06:36
@zhu-xiaowei zhu-xiaowei marked this pull request as ready for review September 20, 2023 07:28
@zxkane zxkane merged commit 41ff6e1 into main Sep 21, 2023
@zxkane zxkane deleted the fix_engagement_time branch September 21, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants