chore: Add support for custom key prefixes in Idempotency utility #745
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #703
Summary
Changes
This pull request introduces a new feature to allow custom prefixes for idempotency keys in the Idempotency utility. The changes include updates to the
IdempotentAttribute
class, theIdempotencyAspectHandler
class, and various test cases to support and validate the new feature (including E2E tests).New Feature: Custom Prefix for Idempotency Key
libraries/src/AWS.Lambda.Powertools.Idempotency/IdempotentAttribute.cs
: Added aKeyPrefix
property to theIdempotentAttribute
class to allow custom prefixes for idempotency keys. Updated theWrapSync
andWrapAsync
methods to pass theKeyPrefix
to theIdempotencyAspectHandler
. [1] [2] [3]libraries/src/AWS.Lambda.Powertools.Idempotency/Internal/IdempotencyAspectHandler.cs
: Modified the constructor ofIdempotencyAspectHandler
to accept akeyPrefix
parameter and updated theConfigure
method of the persistence store to use thekeyPrefix
if provided.Persistence Store Configuration
libraries/src/AWS.Lambda.Powertools.Idempotency/Persistence/BasePersistenceStore.cs
: Updated theConfigure
method to handle the newkeyPrefix
parameter. If thekeyPrefix
is provided, it is used as the function name; otherwise, the environment variable or default value is used. [1] [2]Test Cases
Added new test cases to validate the custom prefix functionality:
libraries/tests/AWS.Lambda.Powertools.Idempotency.Tests/Handlers/IdempotencyAttributeWithCustomKeyPrefix.cs
: Added a new handler to test idempotency with a custom key prefix on a method.libraries/tests/AWS.Lambda.Powertools.Idempotency.Tests/Handlers/IdempotencyHandlerWithCustomKeyPrefix.cs
: Added a new handler to test idempotency with a custom key prefix on a handler.libraries/tests/AWS.Lambda.Powertools.Idempotency.Tests/Internal/IdempotentAspectTests.cs
: Added new test methods to validate the custom prefix key functionality for both handlers and methods.Updated existing test cases to include the
keyPrefix
parameter where necessary:libraries/tests/AWS.Lambda.Powertools.Idempotency.Tests/Persistence/BasePersistenceStoreTests.cs
: Updated various test methods to pass thekeyPrefix
parameter to theConfigure
method. [1] [2] [3] [4] [5] [6] [7] [8] [9]User experience
Checklist
Please leave checklist items unchecked if they do not apply to your change.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.