Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update test projects to no be packable #731

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

hjgraca
Copy link
Contributor

@hjgraca hjgraca commented Jan 28, 2025

Please provide the issue number

Issue number: #723

Summary

Changes

<PropertyGroup>
    <IsPackable>false</IsPackable>
</PropertyGroup>

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

    <PropertyGroup>
        <IsPackable>false</IsPackable>
    </PropertyGroup>

Signed-off-by: Henrique Graca <999396+hjgraca@users.noreply.github.com>
@auto-assign auto-assign bot requested review from amirkaws and sliedig January 28, 2025 11:38
@boring-cyborg boring-cyborg bot added the tests label Jan 28, 2025
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 28, 2025
Signed-off-by: Henrique Graca <999396+hjgraca@users.noreply.github.com>
@github-actions github-actions bot added the internal Maintenance changes label Jan 28, 2025
@hjgraca hjgraca merged commit 5f17cc2 into develop Jan 28, 2025
4 checks passed
@hjgraca hjgraca deleted the patch-do-not-pack-tests branch January 28, 2025 11:40
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.34%. Comparing base (ff2403e) to head (0dc6118).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #731   +/-   ##
========================================
  Coverage    73.34%   73.34%           
========================================
  Files          200      200           
  Lines         8112     8112           
  Branches       871      871           
========================================
  Hits          5950     5950           
  Misses        1874     1874           
  Partials       288      288           
Flag Coverage Δ
unittests 73.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Maintenance changes size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants