Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update logging aot docs #649

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

hjgraca
Copy link
Contributor

@hjgraca hjgraca commented Sep 24, 2024

Please provide the issue number

Issue number: #628

Summary

Changes

Update docs

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@auto-assign auto-assign bot requested a review from amirkaws September 24, 2024 09:51
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Sep 24, 2024
@auto-assign auto-assign bot requested a review from sliedig September 24, 2024 09:51
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 24, 2024
@github-actions github-actions bot added the internal Maintenance changes label Sep 24, 2024
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 24, 2024
@boring-cyborg boring-cyborg bot added the tests label Sep 24, 2024
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.94%. Comparing base (335eef7) to head (243db4d).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #649      +/-   ##
===========================================
+ Coverage    72.91%   72.94%   +0.02%     
===========================================
  Files          195      195              
  Lines         7986     7986              
  Branches       854      854              
===========================================
+ Hits          5823     5825       +2     
+ Misses        1877     1876       -1     
+ Partials       286      285       -1     
Flag Coverage Δ
unittests 72.94% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leandrodamascena leandrodamascena self-requested a review September 24, 2024 10:34
@hjgraca hjgraca merged commit 434add6 into aws-powertools:develop Sep 24, 2024
7 checks passed
@hjgraca hjgraca deleted the (docs)-update-logging-aot branch September 24, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation internal Maintenance changes size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants