Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable publish from rn-datastore branch #4899

Conversation

Ashish-Nanda
Copy link
Contributor

Description of changes:
Enable publish from rn-datastore branch

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Feb 12, 2020

Codecov Report

Merging #4899 into rn-datastore will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           rn-datastore    #4899   +/-   ##
=============================================
  Coverage         76.37%   76.37%           
=============================================
  Files               175      175           
  Lines              9659     9659           
  Branches           1981     1923   -58     
=============================================
  Hits               7377     7377           
- Misses             2135     2143    +8     
+ Partials            147      139    -8     
Impacted Files Coverage Δ
packages/auth/src/OAuth/OAuth.ts 48.12% <0.00%> (ø) ⬆️
packages/core/src/OAuthHelper/GoogleOAuth.ts 31.25% <0.00%> (ø) ⬆️
packages/xr/src/Providers/SumerianProvider.ts 47.55% <0.00%> (ø) ⬆️
packages/core/src/OAuthHelper/FacebookOAuth.ts 34.09% <0.00%> (ø) ⬆️
...ackages/pubsub/src/Providers/AWSAppSyncProvider.ts 66.66% <0.00%> (ø) ⬆️
...pubsub/src/Providers/AWSAppSyncRealTimeProvider.ts 18.41% <0.00%> (ø) ⬆️
...rc/Providers/AmazonAIConvertPredictionsProvider.ts 61.23% <0.00%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3525333...9690af0. Read the comment docs.

Copy link
Contributor

@elorzafe elorzafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Ashish-Nanda Ashish-Nanda merged commit 0d78e16 into aws-amplify:rn-datastore Feb 12, 2020
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants