Feat: support relative media paths via config #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So you realize the problem yourself now? |
|
This has nothing to do with your previous PR. But if it makes you feel better about yourself then sure you were right. |
|
My previous PR is because I want to use relative media path |
|
I'm not going to do this with you. You're PR didn't solve the issue and was therefore not merged. You can now use your relative urls. Please feel free to write you're own plugin and do what ever you want with it. But there is zero need to bring your closed Pr into this at this time. |
|
Would you please implement this relative path support into v2? |
|
I'm open to a PR for it, but have no plans to back port features into previous versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.