Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add_pcidevice: format cmd line to json #3800

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

quanwenli
Copy link
Contributor

ID: 1552
Signed-off-by: Wenli Quan wquan@redhat.com

@quanwenli
Copy link
Contributor Author

JOB LOG : /root/avocado/job-results/job-2023-11-21T16.51-9239321/job.log
(1/1) BF3.vfio_test.1q.acceptance.repeat1.Host_RHEL.m9.u4.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.4.0.x86_64.io-github-autotest-qemu.netperf.with_jumbo.host_guest.q35: STARTED
(1/1) BF3.vfio_test.1q.acceptance.repeat1.Host_RHEL.m9.u4.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.4.0.x86_64.io-github-autotest-qemu.netperf.with_jumbo.host_guest.q35: PASS (311.95 s)
RESULTS : PASS 1 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML : /root/avocado/job-results/job-2023-11-21T16.51-9239321/results.html

@quanwenli
Copy link
Contributor Author

@nickzhq could you help review this ? Thanks

@YongxueHong YongxueHong self-requested a review November 29, 2023 09:18
@nickzhq
Copy link
Contributor

nickzhq commented Nov 29, 2023

Hello @quanwenli , based on your commit, do you want to cover the line dev = qdevices.QCustomDevice('pcidevice', parent_bus=pci_bus) ?
If Not, your code is okay to me.
If yes, the device can NOT be present in json format.

@quanwenli
Copy link
Contributor Author

Hello @quanwenli , based on your commit, do you want to cover the line dev = qdevices.QCustomDevice('pcidevice', parent_bus=pci_bus) ? If Not, your code is okay to me.

I do not have this requirement.

If yes, the device can NOT be present in json format.

@nickzhq
Copy link
Contributor

nickzhq commented Nov 29, 2023

Hello @quanwenli , based on your commit, do you want to cover the line dev = qdevices.QCustomDevice('pcidevice', parent_bus=pci_bus) ? If Not, your code is okay to me.

I do not have this requirement.

If yes, the device can NOT be present in json format.

FYI, cc @YongxueHong @zhencliu

@zhencliu
Copy link
Contributor

zhencliu commented Dec 5, 2023

If yes, the device can NOT be present in json format.

Hello @quanwenli , based on your commit, do you want to cover the line dev = qdevices.QCustomDevice('pcidevice', parent_bus=pci_bus) ? If Not, your code is okay to me.

I do not have this requirement.

Then we may put the format setting line under line 938, it's not a good idea to put it here for it also handles qdevices.QCustomDevice even we don't use it any more, cc @YongxueHong

If yes, the device can NOT be present in json format.

FYI, cc @YongxueHong @zhencliu

Signed-off-by: Wenli Quan <wquan@redhat.com>
@quanwenli
Copy link
Contributor Author

If yes, the device can NOT be present in json format.

Hello @quanwenli , based on your commit, do you want to cover the line dev = qdevices.QCustomDevice('pcidevice', parent_bus=pci_bus) ? If Not, your code is okay to me.

I do not have this requirement.

Then we may put the format setting line under line 938, it's not a good idea to put it here for it also handles qdevices.QCustomDevice even we don't use it any more, cc @YongxueHong

I have updated it under the line 938.

If yes, the device can NOT be present in json format.

FYI, cc @YongxueHong @zhencliu

@quanwenli
Copy link
Contributor Author

JOB LOG : /root/avocado/job-results/job-2023-12-05T17.04-4c794e0/job.log
(1/1) BF3.vfio_test.1q.acceptance.repeat1.Host_RHEL.m9.u4.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.4.0.x86_64.io-github-autotest-qemu.netperf.with_jumbo.host_guest.q35: STARTED
BF3.vfio_test.1q.acceptance.repeat1.Host_RHEL.m9.u4.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.4.0.x86_64.io-github-autotest-qemu.netperf.with_jumbo.host_guest.q35: PASS (378.49 s)

@YongxueHong YongxueHong merged commit d798d84 into avocado-framework:master Dec 6, 2023
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants