Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: whatsapp api update #21

Merged
merged 3 commits into from
Jan 29, 2018
Merged

feat: whatsapp api update #21

merged 3 commits into from
Jan 29, 2018

Conversation

zalog
Copy link
Contributor

@zalog zalog commented Jan 29, 2018

I think we can use whatsapp api.
Tested on android and web chrome.

@avdeev
Copy link
Owner

avdeev commented Jan 29, 2018

@zalog Thanks!
Very good new API
Can you update tests and use window.open instead of mobileShare helper?

@zalog
Copy link
Contributor Author

zalog commented Jan 29, 2018

Oh! Missed that, it was a quick pr made directly on github.
I can validate the tests today :)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 55ec6a9 on zalog:patch-1 into c7f5fb2 on avdeev:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 55ec6a9 on zalog:patch-1 into c7f5fb2 on avdeev:master.

@zalog
Copy link
Contributor Author

zalog commented Jan 29, 2018

Back! Please take a look now.

@avdeev avdeev merged commit 0df7a7f into avdeev:master Jan 29, 2018
@zalog zalog deleted the patch-1 branch January 29, 2018 16:36
@avdeev
Copy link
Owner

avdeev commented Jan 29, 2018

@zalog Thanks!
I will prepare docs and demo, and then I'll release

@zalog
Copy link
Contributor Author

zalog commented Jan 30, 2018

Great! Glad I could help. I'll keep an eye on you.
You have a star :)

@avdeev
Copy link
Owner

avdeev commented Jan 30, 2018

@zalog I released package with new Whatsapp API
You can help with testing and new popular sharers. :)

@zalog
Copy link
Contributor Author

zalog commented Jan 31, 2018

Oh, you added phone! 👍

@avdeev
Copy link
Owner

avdeev commented Jan 31, 2018

Yes.
I decided not to change the original interface much.
Although this is not a useful parameter for sharing.

@zalog
Copy link
Contributor Author

zalog commented Jan 31, 2018

Yes, It's not.
But I have projects that need "send me a whatsapp message", and we have covered this case too, witch is great. Especially that is about a simple parameter, so it's effortless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants