Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve caller detection #59

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Improve caller detection #59

merged 1 commit into from
Jul 11, 2023

Conversation

actualwitch
Copy link
Contributor

@actualwitch actualwitch commented Jul 5, 2023 •
edited
Loading

  • Change decorator behavior to keep track of caller according to spec
  • Switch to qualified names for functions to uniquely point to a function in file
  • Use module's __name__ for label which uses package names instead of just fs path
  • Linting now runs both python 3.11, 3.7 and even latest pypy

@actualwitch actualwitch force-pushed the improved-caller-detection branch 13 times, most recently from c29f18e to 6aaab48 Compare July 6, 2023 14:23
@actualwitch actualwitch requested review from brettimus and flenter July 6, 2023 14:34
@actualwitch actualwitch force-pushed the improved-caller-detection branch from 6aaab48 to 992af8e Compare July 6, 2023 14:39
flenter
flenter approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@flenter flenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Now in line with the spec 🎉

@actualwitch actualwitch force-pushed the improved-caller-detection branch 6 times, most recently from 61ce466 to 7b6dfcf Compare July 11, 2023 13:24
@actualwitch actualwitch force-pushed the improved-caller-detection branch from 7b6dfcf to 33dc4c0 Compare July 11, 2023 13:25
@actualwitch actualwitch merged commit 37920c0 into main Jul 11, 2023
@actualwitch actualwitch mentioned this pull request Jul 11, 2023
Closed
@actualwitch actualwitch deleted the improved-caller-detection branch July 12, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flenter flenter flenter approved these changes

@brettimus brettimus Awaiting requested review from brettimus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@actualwitch @flenter