Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slo support #16

Merged
merged 23 commits into from
Apr 13, 2023
Merged

Conversation

flenter
Copy link
Member

@flenter flenter commented Apr 6, 2023

This PR also includes:

  • a refactor for a large portion of the code
  • updates the workflow to run black & tests during ci
  • changes the way exceptions are handled: the decorator will now rethrow the exception instead of just returning the error

Closes #16

@flenter flenter requested review from v-aparna and removed request for v-aparna April 6, 2023 14:09
@flenter flenter marked this pull request as draft April 6, 2023 14:19
@flenter flenter force-pushed the fp-3168-autometrics-py-feature-add-slo-support branch 2 times, most recently from 3846165 to dc7b595 Compare April 11, 2023 09:20
@flenter flenter force-pushed the fp-3168-autometrics-py-feature-add-slo-support branch from dc7b595 to 6734323 Compare April 11, 2023 09:23
@flenter flenter force-pushed the fp-3168-autometrics-py-feature-add-slo-support branch from eea8cba to 7796cc5 Compare April 12, 2023 08:00
@flenter flenter force-pushed the fp-3168-autometrics-py-feature-add-slo-support branch from dae3210 to 1869f79 Compare April 12, 2023 09:36
@flenter flenter marked this pull request as ready for review April 12, 2023 15:35
@flenter flenter requested a review from actualwitch April 12, 2023 15:37
@flenter flenter requested review from v-aparna and brettimus April 12, 2023 15:37
README.md Outdated Show resolved Hide resolved
@brettimus
Copy link
Collaborator

brettimus commented Apr 13, 2023

regarding the examples:

is there a simple way to point them to the code from the repo? (so that they run based off of what is in the repo) i wasn't totally clear on how to run them

or should we prefer that they run based off of what's the most recently published package?

@v-aparna
Copy link
Collaborator

v-aparna commented Apr 13, 2023

regarding the examples:

is there a simple way to point them to the code from the repo? (so that they run based off of what is in the repo) i wasn't totally clear on how to run them

or should we prefer that they run based off of what's the most recently published package?

The current examples do not work with the recently published package, for them to work, a local package can be built and then used (python -m build). However, I feel examples are run better off the published package.

@brettimus brettimus merged commit c364676 into main Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants